Splitting out the generation of the argument parser for the CLI#105
Merged
julianstirling merged 2 commits intomainfrom Jun 6, 2025
Merged
Splitting out the generation of the argument parser for the CLI#105julianstirling merged 2 commits intomainfrom
julianstirling merged 2 commits intomainfrom
Conversation
The generation of the argument parser is now a seperate function from calling it. This allows downstream programs to add extra functionality to their argument parser if needed.
julianstirling
force-pushed
the
split-out-arg-parser
branch
from
73ed435 to
1dfa84a
Compare
Barecheck - Code coverage reportTotal: 84.09%Your code coverage diff: 0.01% ▴ Uncovered files and lines
|
julianstirling
changed the title
JohemianKnapsody
requested changes
Jun 6, 2025
Collaborator
JohemianKnapsody
left a comment
JohemianKnapsody
left a comment
There was a problem hiding this comment.
One minor change that I think makes it clearer
Co-authored-by: Julian Stirling <julian@julianstirling.co.uk>
JohemianKnapsody
approved these changes
Jun 6, 2025
Collaborator
JohemianKnapsody
left a comment
JohemianKnapsody
left a comment
There was a problem hiding this comment.
With that comment, I understand better what's going on, which seems like a good sign for a comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The generation of the argument parser is now a seperate function from calling it. This allows downstream programs to add extra functionality to their argument parser if needed.